Skip to content

Update ComponentFlagz milestones and PRR #5611 #5612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 16, 2025
Merged

Update ComponentFlagz milestones and PRR #5611 #5612

merged 2 commits into from
Oct 16, 2025
+11 −7

Conversation

@richabanker
Copy link
Contributor

/hold

For #5550 to be merged first

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels Oct 4, 2025
@k8s-ci-robot k8s-ci-robot added sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 4, 2025
@richabanker
Copy link
Contributor Author

@jpbetz would it be possible for you to review PRR for this as well? Mostly its the same as #5611, there's only a few minor tweaks.

jpbetz
jpbetz approved these changes Oct 6, 2025
View reviewed changes
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpbetz, richabanker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@richabanker richabanker force-pushed the flagz-prr branch 2 times, most recently from 3a80f85 to d08e4ff Compare October 7, 2025 21:35
jpbetz
jpbetz reviewed Oct 14, 2025
View reviewed changes
@richabanker richabanker changed the title PRR for structured ComponentFlagz #5611 Update ComponentFlagz milestones and PRR #5611 Oct 14, 2025
@dgrisonnet
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2025
@richabanker
Copy link
Contributor Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 16, 2025
@k8s-ci-robot k8s-ci-robot merged commit cf0c83e into kubernetes:master Oct 16, 2025
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.35 milestone Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jpbetz jpbetz jpbetz approved these changes

@dashpole dashpole Awaiting requested review from dashpole

@rexagod rexagod Awaiting requested review from rexagod

Assignees

@dgrisonnet dgrisonnet

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

v1.35

Development

Successfully merging this pull request may close these issues.

4 participants

@richabanker @k8s-ci-robot @dgrisonnet @jpbetz